Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes added for last 24 hour node history bug #7724

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

AadeshNichite
Copy link
Contributor

@AadeshNichite AadeshNichite commented Feb 14, 2023

Signed-off-by: AadeshNichite anichite@progress.com

🔩 Description: What code changed, and why?

Made changes in two APIS (GetRuns, cfgmgmt) to accept UTC time format as well. Updated frontend function change to send data with API with respect to selected dropdown.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-255

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screen.Recording.2023-02-14.at.3.43.15.PM.mov

Signed-off-by: AadeshNichite <54974312+AadeshNichite@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 14, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 42fc033
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63ecb3c60a35fc000724636d

@YashviJain01 YashviJain01 self-requested a review February 14, 2023 05:05
Signed-off-by: AadeshNichite <54974312+AadeshNichite@users.noreply.github.com>
Signed-off-by: AadeshNichite <54974312+AadeshNichite@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit bb4c02c into main Feb 21, 2023
@kalroy kalroy deleted the Aadesh/KINETICS-255 branch February 21, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants